Shifting to Protobuf Serialization - Cleaned #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yet implemented.
suidpit
force-pushed
the
protobuf-serialization-clean
branch
from
22aadc9
to
d5da746
Compare
|
So, can this be merged? I'll work on these files, and use this interface, in the next few PRs, so I need it to proceed! |
mhils
approved these changes
Jul 20, 2018
| @@ -0,0 +1,93 @@ | |||
| syntax='proto2'; | |||
There was a problem hiding this comment.
Is there a particular reason why we went with proto2 and not proto3?
(both is fine with me, just curious)
There was a problem hiding this comment.
Nothing in particular. I found more documentation and examples for proto2 syntax, and I didn't want to preclude required fields in messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be clean and ready to be merged. I have checked out tmp.sqlite from both repo and history (.sqlite files are now ignored by git) and refactored DbHandler class into the righteous DBHandler.
Let me know if anything else has to be addressed.